lkml.org 
[lkml]   [2014]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCHv2 2/3] kernel: add support for live patching
    On Tue, Nov 18, 2014 at 03:11:43PM +0100, Miroslav Benes wrote:
    >
    > Hi,
    >
    > thank you for the revision. I'll rebase our patches on top of that. Anyway
    > there is a small bug in a header file. See below.
    >
    > On Sun, 16 Nov 2014, Seth Jennings wrote:
    >
    > [...]
    >
    > > diff --git a/arch/x86/include/asm/livepatch.h
    > b/arch/x86/include/asm/livepatch.h
    > > new file mode 100644
    > > index 0000000..c5fab45
    > > --- /dev/null
    > > +++ b/arch/x86/include/asm/livepatch.h
    > > @@ -0,0 +1,38 @@
    > > +/*
    > > + * livepatch.h - x86-specific Live Kernel Patching Core
    > > + *
    > > + * Copyright (C) 2014 Seth Jennings <sjenning@redhat.com>
    > > + *
    > > + * This program is free software; you can redistribute it and/or
    > > + * modify it under the terms of the GNU General Public License
    > > + * as published by the Free Software Foundation; either version 2
    > > + * of the License, or (at your option) any later version.
    > > + *
    > > + * This program is distributed in the hope that it will be useful,
    > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
    > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
    > > + * GNU General Public License for more details.
    > > + *
    > > + * You should have received a copy of the GNU General Public License
    > > + * along with this program; if not, see <http://www.gnu.org/licenses/>.
    > > + */
    > > +
    > > +#ifndef _ASM_X86_LIVEPATCH_H
    > > +#define _ASM_X86_LIVEPATCH_H
    > > +
    > > +#include <linux/module.h>
    > > +
    > > +#ifdef CONFIG_LIVE_PATCHING
    > > +extern int lpc_write_module_reloc(struct module *mod, unsigned long
    > type,
    > > + unsigned long loc, unsigned long value);
    > > +
    > > +#else
    > > +static int lpc_write_module_reloc(struct module *mod, unsigned long
    > type,
    > > + unsigned long loc, unsigned long value);
    > > +{
    > > + pr_err("Kernel does not support live patching\n");
    > > + return -ENOSYS;
    > > +}
    > > +#endif
    > > +
    > > +#endif /* _ASM_X86_LIVEPATCH_H */
    >
    > There should not be a semicolon at the end of the function header in #else
    > branch.

    Good catch.

    Also, I'm adding "build with LIVE_PATCHING=n" as a test step :-/

    Thanks,
    Seth

    >
    > Regards,
    >
    > ---
    > Miroslav Benes
    > SUSE Labs


    \
     
     \ /
      Last update: 2014-11-18 16:01    [W:4.079 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site