| From | David Howells <> | Subject | Re: [PATCH 16/16] rxrpc: Replace smp_read_barrier_depends() with lockless_dereference() | Date | Thu, 13 Nov 2014 20:17:39 +0000 |
| |
Pranith Kumar <bobby.prani@gmail.com> wrote:
> loop != call->acks_head || stop; > loop = (loop + 1) & (call->acks_winsz - 1) > ) { > - p_txb = call->acks_window + loop; > - smp_read_barrier_depends(); > + p_txb = lockless_dereference(call)->acks_window + loop;
Nack. You've stuck an implicit barrier on a dereference that doesn't matter. And similar for other hunks of this patch.
David
|