lkml.org 
[lkml]   [2014]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 16/16] rxrpc: Replace smp_read_barrier_depends() with lockless_dereference()
Date
Pranith Kumar <bobby.prani@gmail.com> wrote:

> loop != call->acks_head || stop;
> loop = (loop + 1) & (call->acks_winsz - 1)
> ) {
> - p_txb = call->acks_window + loop;
> - smp_read_barrier_depends();
> + p_txb = lockless_dereference(call)->acks_window + loop;

Nack. You've stuck an implicit barrier on a dereference that doesn't matter.
And similar for other hunks of this patch.

David


\
 
 \ /
  Last update: 2014-11-13 21:41    [W:0.101 / U:2.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site