lkml.org 
[lkml]   [2014]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 06/16] assoc_array: Replace smp_read_barrier_depends() with lockless_dereference()
Date
Pranith Kumar <bobby.prani@gmail.com> wrote:

> static inline bool assoc_array_ptr_is_meta(const struct assoc_array_ptr *x)
> {
> - return (unsigned long)x & ASSOC_ARRAY_PTR_TYPE_MASK;
> + return (unsigned long)lockless_dereference(x) &
> + ASSOC_ARRAY_PTR_TYPE_MASK;
> }

Nack. x is not being dereferenced here, nor in some of the other places
you've added this.

David


\
 
 \ /
  Last update: 2014-11-13 21:41    [W:0.126 / U:0.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site