| From | David Howells <> | Subject | Re: [PATCH 06/16] assoc_array: Replace smp_read_barrier_depends() with lockless_dereference() | Date | Thu, 13 Nov 2014 20:11:16 +0000 |
| |
Pranith Kumar <bobby.prani@gmail.com> wrote:
> static inline bool assoc_array_ptr_is_meta(const struct assoc_array_ptr *x) > { > - return (unsigned long)x & ASSOC_ARRAY_PTR_TYPE_MASK; > + return (unsigned long)lockless_dereference(x) & > + ASSOC_ARRAY_PTR_TYPE_MASK; > }
Nack. x is not being dereferenced here, nor in some of the other places you've added this.
David
|