| Date | Wed, 12 Nov 2014 17:43:57 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [patch 16/16] PCI/MSI: Enhance core to support hierarchy irqdomain |
| |
On Wed, 12 Nov 2014, Marc Zyngier wrote: > > +#ifdef CONFIG_PCI_MSI_IRQ_DOMAIN > > +void pci_msi_domain_write_msg(struct irq_data *irq_data, struct msi_msg *msg) > > +{ > > + struct msi_desc *desc = irq_data->msi_desc; > > + > > + /* > > + * MSI-X message is written per-IRQ. > > + * MSI message denotes a contiguous group of IRQs, written for 0th IRQ. > > + */ > > + if (desc->irq == irq_data->irq) > > + pci_write_msi_msg(desc, msg); > > My compiler barks at this. Shouldn't that be either: > pci_write_msi_msg(desc->irq, msg); > or > __pci_write_msi_msg(desc, msg);
The latter.
Thanks,
tglx
|