lkml.org 
[lkml]   [2014]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86, boot: add hex output for debugging
On 10/31/2014 01:11 PM, Vivek Goyal wrote:
> On Fri, Oct 31, 2014 at 10:42:51AM -0700, Andi Kleen wrote:
>>>> +void __puthex(unsigned long value)
>>>> +{
>>>> + char alpha[2] = "0";
>>>> + int bits;
>>>> + unsigned char byte;
>>>
>>> what is 'byte' for? (unused)
>>
>> Well the whole function is unused. We don't normally add unused functions
>> to the code because they bitrot too easily.
>
> I think this is useful. I had to write similar code for printing out
> values during early boot.
>
> May be we can print some values if CONFIG_X86_VERBOSE_BOOTUP=y.
> That way it will not be an unused code and others can reuse it easily
> to print additional data during debugging.
>

The various addresses involved in decompression (load address, relocated
address, etc.) might be good ideas.

-hpa




\
 
 \ /
  Last update: 2014-10-31 21:41    [W:0.037 / U:0.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site