Messages in this thread | | | Date | Fri, 31 Oct 2014 16:11:56 -0400 | From | Vivek Goyal <> | Subject | Re: [PATCH] x86, boot: add hex output for debugging |
| |
On Fri, Oct 31, 2014 at 10:42:51AM -0700, Andi Kleen wrote: > > > +void __puthex(unsigned long value) > > > +{ > > > + char alpha[2] = "0"; > > > + int bits; > > > + unsigned char byte; > > > > what is 'byte' for? (unused) > > Well the whole function is unused. We don't normally add unused functions > to the code because they bitrot too easily.
I think this is useful. I had to write similar code for printing out values during early boot.
May be we can print some values if CONFIG_X86_VERBOSE_BOOTUP=y. That way it will not be an unused code and others can reuse it easily to print additional data during debugging.
Thanks Vivek
| |