Messages in this thread | | | Date | Thu, 30 Oct 2014 18:04:49 -0700 | Subject | Re: [RFC PATCH] fs: allow open(dir, O_TMPFILE|..., 0) with mode 0 | From | Linus Torvalds <> |
| |
On Thu, Oct 30, 2014 at 5:57 PM, Eric Rannaud <e@nanocritical.com> wrote: > > Yes, there definitely is a glibc bug: a fix is being worked on and it > looks like it will go in. The change replaces the test for O_CREAT by > a test for either O_CREAT or O_TMPFILE.
Why not just do it unconditionally? There really is no downside. Doing it conditionally only makes the generated code slower and mode complex. For absolutely zero gain, as far as I can tell. Does any architecture actually do anything wrong?
It's actually closer in spirit to the original "open()" model than the existing code.
Linus
| |