Messages in this thread | | | Date | Thu, 30 Oct 2014 15:58:18 -0700 | Subject | Re: [RFC PATCH] fs: allow open(dir, O_TMPFILE|..., 0) with mode 0 | From | Linus Torvalds <> |
| |
On Thu, Oct 30, 2014 at 3:48 PM, Linus Torvalds <torvalds@linux-foundation.org> wrote: > > Agreed. Will apply and add the stable cc.
Ho humm. Thinking about this some more, I'm starting to wonder. Not about this patch per se (open on a newly created file should indeed succeed regardless), but about the horrible glibc behavior of screwing up the third argument.
If you want to do O_TMPFILE + linkat() (or some eventual future flink()), the mode really matters. So this idiotic glibc behavior of only forwarding the third argument if O_CREAT is set seems to be a bug.
Why the hell does glibc think it's a good idea to intersect system call semantics? It's not a good idea - it's just stupid in the extreme. And in this case it seems to actively breaks things.
Linus
| |