Messages in this thread | | | Date | Fri, 3 Oct 2014 15:43:59 -0500 | From | Michael Welling <> | Subject | Re: [PATCH] drivers:ethernet:davinci_emac.c:Fixes flaw in mac address handling. |
| |
On Fri, Oct 03, 2014 at 01:03:05PM -0700, David Miller wrote: > From: Michael Welling <mwelling@ieee.org> > Date: Wed, 1 Oct 2014 21:32:05 -0500 > > > The code currently checks the mac_addr variable that is clearly > > zero'd out during allocation. > > > > Further code is added to bring the mac_addr from the partial pdata. > > > > Signed-off-by: Michael Welling <mwelling@ieee.org> > > I don't see anyone specifying a MAC address in the partial pdata, > so better to just delete that field. > > Even if people did, I am not so sure that the partial pdata should > unconditionally trump an OF provided MAC address.
So should I just leave the code for handling the mac_addr field from the partial pdata out or make it such that the mac_addr field is overriden if specified from the devicetree?
| |