Messages in this thread | | | Date | Fri, 03 Oct 2014 13:03:05 -0700 (PDT) | Subject | Re: [PATCH] drivers:ethernet:davinci_emac.c:Fixes flaw in mac address handling. | From | David Miller <> |
| |
From: Michael Welling <mwelling@ieee.org> Date: Wed, 1 Oct 2014 21:32:05 -0500
> The code currently checks the mac_addr variable that is clearly > zero'd out during allocation. > > Further code is added to bring the mac_addr from the partial pdata. > > Signed-off-by: Michael Welling <mwelling@ieee.org>
I don't see anyone specifying a MAC address in the partial pdata, so better to just delete that field.
Even if people did, I am not so sure that the partial pdata should unconditionally trump an OF provided MAC address.
| |