Messages in this thread | | | Date | Fri, 03 Oct 2014 13:42:46 -0600 | From | Shuah Khan <> | Subject | Re: [PATCH v3 3/5] selftests/ipc: change test to use ksft framework |
| |
On 10/03/2014 11:39 AM, Davidlohr Bueso wrote: > On Fri, 2014-10-03 at 09:36 -0600, Shuah Khan wrote: >> msgque.key = ftok(argv[0], 822155650); >> if (msgque.key == -1) { >> - printf("Can't make key\n"); >> - return -errno; >> + printf("Can't make key: %d\n", -errno); > > So printing a numeric value is quite useless when users actually run > into these errors -- which is why I like err() so much. How about using > strerror() instead? >
Yes. using perror() does give better information. There are other places in this file that use errno. How about I make that a separate patch and catch all of them at once to use perror() as a follow-up change? That way I fix all at once without adding more changes to this patch.
thanks, -- Shuah
-- Shuah Khan Sr. Linux Kernel Developer Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978
| |