lkml.org 
[lkml]   [2014]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 3/5] selftests/ipc: change test to use ksft framework
From
Date
On Fri, 2014-10-03 at 09:36 -0600, Shuah Khan wrote:
> msgque.key = ftok(argv[0], 822155650);
> if (msgque.key == -1) {
> - printf("Can't make key\n");
> - return -errno;
> + printf("Can't make key: %d\n", -errno);

So printing a numeric value is quite useless when users actually run
into these errors -- which is why I like err() so much. How about using
strerror() instead?

Thanks,
Davidlohr



\
 
 \ /
  Last update: 2014-10-03 20:21    [W:0.051 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site