Messages in this thread | | | Date | Wed, 29 Oct 2014 17:41:36 +0100 | From | Andrea Arcangeli <> | Subject | Re: [PATCH 2/4] mm: gup: add get_user_pages_locked and get_user_pages_unlocked |
| |
On Thu, Oct 09, 2014 at 12:47:23PM +0200, Peter Zijlstra wrote: > On Wed, Oct 01, 2014 at 10:56:35AM +0200, Andrea Arcangeli wrote: > > +static inline long __get_user_pages_locked(struct task_struct *tsk, > > + struct mm_struct *mm, > > + unsigned long start, > > + unsigned long nr_pages, > > + int write, int force, > > + struct page **pages, > > + struct vm_area_struct **vmas, > > + int *locked, > > + bool notify_drop) > > You might want to consider __always_inline to make sure it does indeed > get inlined and constant propagation works for @locked and @notify_drop.
Ok, that's included in the last patchset submit.
Thanks, Andrea
| |