Messages in this thread | | | Date | Thu, 9 Oct 2014 12:47:23 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH 2/4] mm: gup: add get_user_pages_locked and get_user_pages_unlocked |
| |
On Wed, Oct 01, 2014 at 10:56:35AM +0200, Andrea Arcangeli wrote: > +static inline long __get_user_pages_locked(struct task_struct *tsk, > + struct mm_struct *mm, > + unsigned long start, > + unsigned long nr_pages, > + int write, int force, > + struct page **pages, > + struct vm_area_struct **vmas, > + int *locked, > + bool notify_drop)
You might want to consider __always_inline to make sure it does indeed get inlined and constant propagation works for @locked and @notify_drop.
| |