lkml.org 
[lkml]   [2014]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/8] regulator: max77686: Remove support for board files
From
Date
On wto, 2014-10-28 at 00:37 +0000, Mark Brown wrote:
> On Mon, Oct 27, 2014 at 04:03:40PM +0100, Krzysztof Kozlowski wrote:
> > The driver is used only on Exynos4 based boards with DTS support.
> > Convert the driver to DTS-only version.
>
> This doesn't seem like a particularly persuasive reason honestly and if
> you're going to mess around with this stuff please fix it properly...
>
> > struct max77686_data {
> > + struct max77686_regulator_data *regulators;
> > + int num_regulators;
> > +
>
> ...the only reason for this array and the specification of the number of
> regulators is to make platform data easier to do...
>
> > - pdata->num_regulators = ARRAY_SIZE(regulators);
> > + max77686->num_regulators = ARRAY_SIZE(regulators);
>
> ...and indeed we wind up with a constant here anyway. At the very least
> it'd be better to pull the parsing into the registration, right now we
> have the code still laid out for platform data so it's hard to see it as
> a win in cleanup terms. If we're not translating into platform data we
> shouldn't need to keep this stuff around outside of the probe function.
>
> What would be even better would be to convert to use the standard DT
> parsing with regulators_node and of_match specified in the descriptor
> and then delete most of this code entirely.

You're right, there's a lot to clean in this driver.

The only caveat is that I can't test the max77802 regulator so I
refrained from doing intrusive changes to it. I'll try to clean up both
drivers and make max77802 as RFT.

Best regards,
Krzysztof




\
 
 \ /
  Last update: 2014-10-28 10:21    [W:0.984 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site