lkml.org 
[lkml]   [2014]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] genirq: Allow the irqchip state of an IRQ to be save/restored
On 25/10/14 20:42, Thomas Gleixner wrote:
> On Sat, 25 Oct 2014, Thomas Gleixner wrote:
>
> Bah, hit send way too fast :)
>
>> On Sat, 25 Oct 2014, Marc Zyngier wrote:
>>> +int irq_get_irqchip_state(unsigned int irq, int state)
>
> get_state(state) does not make sense. get_state(which) probably more
> so. And 'which' wants to be an enum btw.
>
>>> + chip_bus_lock(desc);
>>> + val = chip->irq_get_irqchip_state(data, state);
>>
>> Hmm. What's the irq_get_irqchip_state() callback supposed to return?
>
> Either an error code or a boolean value, right? Does not mix very well
> I think.
>
> int irq_get_irqchip_state(unsigned int irq, enum xxx which, bool *val)
>
> Might be a more clear interface.

Agreed, this makes a lot of sense. Will respin it.

Thanks,

M.
--
Jazz is not dead. It just smells funny...



\
 
 \ /
  Last update: 2014-10-27 13:21    [W:0.088 / U:0.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site