Messages in this thread | | | Date | Sat, 25 Oct 2014 21:42:05 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [PATCH 1/3] genirq: Allow the irqchip state of an IRQ to be save/restored |
| |
On Sat, 25 Oct 2014, Thomas Gleixner wrote:
Bah, hit send way too fast :)
> On Sat, 25 Oct 2014, Marc Zyngier wrote: > > +int irq_get_irqchip_state(unsigned int irq, int state)
get_state(state) does not make sense. get_state(which) probably more so. And 'which' wants to be an enum btw.
> > + chip_bus_lock(desc); > > + val = chip->irq_get_irqchip_state(data, state); > > Hmm. What's the irq_get_irqchip_state() callback supposed to return?
Either an error code or a boolean value, right? Does not mix very well I think.
int irq_get_irqchip_state(unsigned int irq, enum xxx which, bool *val)
Might be a more clear interface.
Thanks,
tglx
| |