lkml.org 
[lkml]   [2014]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 2/3] regulator: max77686: Implement suspend disable for some LDOs
On 10/27/2014 11:27 AM, Krzysztof Kozlowski wrote:
>
> Storing opmode in non-shifted form is intuitive also to me. That's way I
> slipped the bug in previous version.
>

Great.

> I'll change this to non-shifted opmode. The patch will grow bigger but
> the code should be more readable.
>

Maybe split in two patches? A preparatory that adds max77686_get_opmode_shift()
and changes the current driver and a second one that implements suspend disable
for LDOs?

> Thanks!

You are welcome.

Best regards,
Javier


\
 
 \ /
  Last update: 2014-10-27 12:01    [W:0.041 / U:0.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site