Messages in this thread | | | Subject | Re: [PATCH v4 2/3] regulator: max77686: Implement suspend disable for some LDOs | From | Krzysztof Kozlowski <> | Date | Mon, 27 Oct 2014 11:35:35 +0100 |
| |
On pon, 2014-10-27 at 11:32 +0100, Javier Martinez Canillas wrote: > On 10/27/2014 11:27 AM, Krzysztof Kozlowski wrote: > > > > Storing opmode in non-shifted form is intuitive also to me. That's way I > > slipped the bug in previous version. > > > > Great. > > > I'll change this to non-shifted opmode. The patch will grow bigger but > > the code should be more readable. > > > > Maybe split in two patches? A preparatory that adds max77686_get_opmode_shift() > and changes the current driver and a second one that implements suspend disable > for LDOs?
Yes, that was the plan :).
> > > Thanks! > > You are welcome. > > Best regards, > Javier
| |