Messages in this thread |  | | Date | Fri, 24 Oct 2014 02:35:18 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH 1/4] vfs: Prepare for adding a new preadv/pwritev with user flags. |
| |
On Tue, Oct 21, 2014 at 04:46:56PM -0400, Milosz Tanski wrote: > Plumbing the flags argument through the vfs code so they can be passed down to > __generic_file_(read/write)_iter function that do the acctual work. > > Signed-off-by: Milosz Tanski <milosz@adfin.com>
The last hunk doesn't belong into this patch, both logically and because the code won't actually compile after applying just this patch.
Otherwise looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
This is the culprit:
> diff --git a/mm/filemap.c b/mm/filemap.c > index 14b4642..cb7f530 100644 > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -1465,7 +1465,7 @@ static void shrink_readahead_size_eio(struct file *filp, > * of the logic when it comes to error handling etc. > */ > static ssize_t do_generic_file_read(struct file *filp, loff_t *ppos, > - struct iov_iter *iter, ssize_t written) > + struct iov_iter *iter, ssize_t written, int flags) > { > struct address_space *mapping = filp->f_mapping; > struct inode *inode = mapping->host;
|  |