Messages in this thread |  | | Date | Fri, 24 Oct 2014 13:08:39 -0400 | Subject | Re: [PATCH 2/4] vfs: Define new syscalls preadv2,pwritev2 | From | Milosz Tanski <> |
| |
On Fri, Oct 24, 2014 at 5:36 AM, Christoph Hellwig <hch@infradead.org> wrote: >> diff --git a/mm/filemap.c b/mm/filemap.c >> index cb7f530..45964c8 100644 >> --- a/mm/filemap.c >> +++ b/mm/filemap.c >> @@ -1735,7 +1735,7 @@ generic_file_read_iter(struct kiocb *iocb, struct iov_iter *iter) >> } >> } >> >> - retval = do_generic_file_read(file, ppos, iter, retval); >> + retval = do_generic_file_read(file, ppos, iter, retval, iocb->ki_rwflags); > > I think this belongs into the last patch, together with the last hunk > from the first patch. > > Otherwise looks good to me: > > Reviewed-by: Christoph Hellwig <hch@lst.de>
I pushed the change from the previous patch to the prototype of do_generic_file_read into this patch.
-- Milosz Tanski CTO 16 East 34th Street, 15th floor New York, NY 10016
p: 646-253-9055 e: milosz@adfin.com
|  |