lkml.org 
[lkml]   [2014]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/4] pinctrl: rockchip: Don't call pinctrl_gpio_direction_output() in pin_config_set()
From
Hi,

On Mon, Oct 20, 2014 at 4:27 PM, Doug Anderson <dianders@chromium.org> wrote:
> @@ -959,9 +968,10 @@ static int rockchip_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
> return rc;
> break;
> case PIN_CONFIG_OUTPUT:
> - rc = rockchip_gpio_direction_output(&bank->gpio_chip,
> - pin - bank->pin_base,
> - arg);
> + rockchip_gpio_set(&bank->gpio_chip,
> + pin - bank->pin_base, arg);
> + rc = _rockchip_pmx_gpio_set_direction(&bank->gpio_chip,
> + pin - bank->pin_base, false);

I think something here is not quite right. I did more testing today
and noticed that I'm getting failures in some cases. I think I've got
the offset wrong, but I'm digging. Please hold off review of this
patch till the next version.


\
 
 \ /
  Last update: 2014-10-21 19:01    [W:0.135 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site