Messages in this thread | | | Date | Thu, 16 Oct 2014 09:30:04 +0200 | From | Mark Brown <> | Subject | Re: [PATCH] spi/atmel: add support for runtime PM |
| |
On Thu, Oct 16, 2014 at 09:49:20AM +0800, Wenyou Yang wrote:
> +static int atmel_spi_runtime_resume(struct device *dev) > +{ > + struct spi_master *master = dev_get_drvdata(dev); > + struct atmel_spi *as = spi_master_get_devdata(master); > + > + pinctrl_pm_select_default_state(dev); > + clk_prepare_enable(as->clk); > +
This looks mostly good but you should check the return value of clk_prepare_enable() - it can fail. [unhandled content-type:application/pgp-signature] | |