lkml.org 
[lkml]   [2014]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] spi/atmel: add support for runtime PM
Date
Hi Mark,

> -----Original Message-----
> From: Mark Brown [mailto:broonie@kernel.org]
> Sent: Thursday, October 16, 2014 3:30 PM
> To: Yang, Wenyou
> Cc: linux-spi@vger.kernel.org; linux-kernel@vger.kernel.org; Ferre, Nicolas; linux-
> arm-kernel@lists.infradead.org
> Subject: Re: [PATCH] spi/atmel: add support for runtime PM
>
> On Thu, Oct 16, 2014 at 09:49:20AM +0800, Wenyou Yang wrote:
>
> > +static int atmel_spi_runtime_resume(struct device *dev) {
> > + struct spi_master *master = dev_get_drvdata(dev);
> > + struct atmel_spi *as = spi_master_get_devdata(master);
> > +
> > + pinctrl_pm_select_default_state(dev);
> > + clk_prepare_enable(as->clk);
> > +
>
> This looks mostly good but you should check the return value of
> clk_prepare_enable() - it can fail.
Thanks a lot, I will add it.

Best Regards,
Wenyou Yang


\
 
 \ /
  Last update: 2014-10-16 10:21    [W:0.088 / U:0.568 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site