Messages in this thread | | | Date | Thu, 16 Oct 2014 21:30:43 +0200 | From | Michael Opdenacker <> | Subject | Re: [PATCH] aic7xxx: replace kmalloc/memset by kzalloc |
| |
Hi Joe,
On 10/16/2014 09:28 PM, Joe Perches wrote: > On Thu, 2014-10-16 at 21:14 +0200, Michael Opdenacker wrote: > > > /* Allocate SCB resources */ > - scb_data->scbarray = kmalloc(sizeof(struct scb) * AHC_SCB_MAX_ALLOC, GFP_ATOMIC); > + scb_data->scbarray = kzalloc(sizeof(struct scb) * AHC_SCB_MAX_ALLOC, > + GFP_ATOMIC); > if (scb_data->scbarray == NULL) > return (ENOMEM); > - memset(scb_data->scbarray, 0, sizeof(struct scb) * AHC_SCB_MAX_ALLOC); > > /* Determine the number of hardware SCBs and initialize them */ > > Probably better as kcalloc.
Hey, well spotted! Thanks for your review. I will post a new version soon.
Cheers,
Michael.
>
-- Michael Opdenacker, CEO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com +33 484 258 098
| |