Messages in this thread | | | Subject | Re: [PATCH] aic7xxx: replace kmalloc/memset by kzalloc | From | Joe Perches <> | Date | Thu, 16 Oct 2014 12:28:40 -0700 |
| |
On Thu, 2014-10-16 at 21:14 +0200, Michael Opdenacker wrote: > This replaces kmalloc + memset by a call to kzalloc. [] > diff --git a/drivers/scsi/aic7xxx/aic7xxx_core.c b/drivers/scsi/aic7xxx/aic7xxx_core.c [] > @@ -4780,10 +4779,10 @@ ahc_init_scbdata(struct ahc_softc *ahc) > SLIST_INIT(&scb_data->sg_maps); > > /* Allocate SCB resources */ > - scb_data->scbarray = kmalloc(sizeof(struct scb) * AHC_SCB_MAX_ALLOC, GFP_ATOMIC); > + scb_data->scbarray = kzalloc(sizeof(struct scb) * AHC_SCB_MAX_ALLOC, > + GFP_ATOMIC); > if (scb_data->scbarray == NULL) > return (ENOMEM); > - memset(scb_data->scbarray, 0, sizeof(struct scb) * AHC_SCB_MAX_ALLOC); > > /* Determine the number of hardware SCBs and initialize them */ >
Probably better as kcalloc.
| |