Messages in this thread | | | Date | Thu, 16 Oct 2014 12:26:36 +0200 | From | Mark Brown <> | Subject | Re: [PATCH 1/2] spi/rockchip: fix bug that case spi can't go as fast as slave request |
| |
On Thu, Oct 16, 2014 at 05:58:51PM +0800, addy ke wrote:
Please fix your mailer to word wrap within paragraphs.
> On 2014/10/16 17:34, Mark Brown wrote:
> >> If we set the rate unconditionally here, clk_set_rate() will be executed in each spi transfer.
> > Is that really such a high cost?
> Not high cost, but I think if the default spi_clk is enough, we do not need to set spi_clk again.
> Maybe we can only set spi_clk as (2 * MAX_SCLK_OUT) in probe().
It's not too bad to do it where it is, it just seems better to be simpler. [unhandled content-type:application/pgp-signature] | |