lkml.org 
[lkml]   [2014]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] spi/rockchip: fix bug that case spi can't go as fast as slave request
hi, Mark

On 2014/10/15 21:04, Mark Brown wrote:
> On Wed, Oct 15, 2014 at 07:25:49PM +0800, Addy Ke wrote:
>
>> + if (WARN_ON(rs->speed > MAX_SCLK_OUT))
>> + rs->speed = MAX_SCLK_OUT;
>> +
>> + /* the minimum divsor is 2 */
>> + if (rs->max_freq < 2 * rs->speed) {
>> + clk_set_rate(rs->spiclk, 2 * rs->speed);
>> + rs->max_freq = clk_get_rate(rs->spiclk);
>> + }
>
> I'll apply this but you should be checking the return code from
> clk_set_rate() here, please send a followup patch doing that. It might

If clk_set_rate return error, do I only put dev_warn here or return error value to spi core?

> also be worth consdering just setting the rate unconditionally here, it
> seems like it should make things simpler.
>
I think we need.
If we set the rate unconditionally here, clk_set_rate() will be executed in each spi transfer.






\
 
 \ /
  Last update: 2014-10-16 11:21    [W:0.177 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site