lkml.org 
[lkml]   [2014]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] spi/rockchip: fix bug that case spi can't go as fast as slave request
On Wed, Oct 15, 2014 at 07:25:49PM +0800, Addy Ke wrote:

> + if (WARN_ON(rs->speed > MAX_SCLK_OUT))
> + rs->speed = MAX_SCLK_OUT;
> +
> + /* the minimum divsor is 2 */
> + if (rs->max_freq < 2 * rs->speed) {
> + clk_set_rate(rs->spiclk, 2 * rs->speed);
> + rs->max_freq = clk_get_rate(rs->spiclk);
> + }

I'll apply this but you should be checking the return code from
clk_set_rate() here, please send a followup patch doing that. It might
also be worth consdering just setting the rate unconditionally here, it
seems like it should make things simpler.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-10-15 15:41    [W:0.064 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site