Messages in this thread Patch in this message |  | | From | Sudip Mukherjee <> | Subject | [PATCH] usb: dwc2: gadget: sparse warning of context imbalance | Date | Fri, 10 Oct 2014 18:39:39 +0530 |
| |
sparse was giving the following warning: warning: context imbalance in 's3c_hsotg_ep_enable' - different lock contexts for basic block
we were returning ENOMEM while still holding the spinlock. The sparse warning was fixed by releasing the spinlock before return.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> --- drivers/usb/dwc2/gadget.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 7b5856f..046e90d 100644 --- a/drivers/usb/dwc2/gadget.c +++ b/drivers/usb/dwc2/gadget.c @@ -2561,8 +2561,10 @@ static int s3c_hsotg_ep_enable(struct usb_ep *ep, hs_ep->fifo_size = val; break; } - if (i == 8) + if (i == 8) { + spin_unlock_irqrestore(&hsotg->lock, flags); return -ENOMEM; + } } /* for non control endpoints, set PID to D0 */ -- 1.8.1.2
|  |