Messages in this thread | | | Date | Fri, 31 Jan 2014 02:27:04 -0800 (PST) | From | David Rientjes <> | Subject | Re: [PATCH] irq: fix a Kconfig dependency |
| |
On Thu, 30 Jan 2014, nitin.a.kamble@intel.com wrote:
> From: Nitin A Kamble <nitin.a.kamble@intel.com> > > The generic_chip.c uses interfaces from irq_domain.c which is controlled by > the IRQ_DOMAIN config option. > > Add a select statement in the Kconfig to reflect this requirement. > > Without this fix, the generic_chip.c compilation fails like this: > > linux/kernel/irq/generic-chip.c:400:11: > error: 'irq_domain_xlate_onetwocell' undeclared here (not in a function) >
You're not specifying which config option you have enabled that selects CONFIG_GENERIC_IRQ_CHIP and does not select CONFIG_IRQ_DOMAIN, but it does look like there is a dependency here.
So, if this dependency is reasonable, it begs the question of why we have CONFIG_GENERIC_IRQ_CHIP at all and shouldn't just make generic-chip.c depend on CONFIG_IRQ_DOMAIN.
| |