lkml.org 
[lkml]   [2014]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] irq: fix a Kconfig dependency
On Fri, 31 Jan 2014, Kamble, Nitin A wrote:

> > So, if this dependency is reasonable, it begs the question of why we have
> > CONFIG_GENERIC_IRQ_CHIP at all and shouldn't just make generic-chip.c
> > depend on CONFIG_IRQ_DOMAIN.
> Looking at the code there are cases where IRQ_DOMAIN functionality is used
> without using the GENERIC_IRQ_CHIP. So making generic-chip.c depend
> on CONFIG_IRQ_DOMAIN in the makefile will reduce the flexibility of using
> these config options separately.
>

Acked-by: David Rientjes <rientjes@google.com>

Although the changelog should be updated since I get a couple problems
when trying to enable CONFIG_GENERIC_IRQ_CHIP without CONFIG_IRQ_DOMAIN on
Linus's latest tree:

kernel/irq/generic-chip.c:400:11: error: ‘irq_domain_xlate_onetwocell’ undeclared here (not in a function)
kernel/irq/generic-chip.c: In function ‘irq_gc_get_irq_data’:
kernel/irq/generic-chip.c:522:2: error: implicit declaration of function ‘irq_find_mapping’ [-Werror=implicit-function-declaration]
\
 
 \ /
  Last update: 2014-01-31 22:01    [W:0.060 / U:2.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site