lkml.org 
[lkml]   [2014]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv3 7/8] zram: drop not used table `count' member
On (01/16/14 14:52), Jerome Marchand wrote:
> On 01/16/2014 02:12 PM, Sergey Senozhatsky wrote:
> > struct table `count' member is not used.
>
> What was the intended use of this counter anyway?
>
> >
> > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > ---
> > drivers/block/zram/zram_drv.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/block/zram/zram_drv.h b/drivers/block/zram/zram_drv.h
> > index 58d4ac5..1d5b1f5 100644
> > --- a/drivers/block/zram/zram_drv.h
> > +++ b/drivers/block/zram/zram_drv.h
> > @@ -64,7 +64,6 @@ enum zram_pageflags {
> > struct table {
> > unsigned long handle;
> > u16 size; /* object size (excluding header) */
> > - u8 count; /* object ref count (not yet used) */
> > u8 flags;
>
>

> I noticed that your earlier version of this patch changed the
> flags size to 16. What has changed?
>

nothing really. I was going to extend flags, but changed my plans. so it was
a leftover.

-ss

> Jerome
>
> > } __aligned(4);
> >
> >
>


\
 
 \ /
  Last update: 2014-01-16 16:01    [W:0.139 / U:0.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site