Messages in this thread | | | Date | Tue, 4 Feb 2014 14:18:49 -0800 | From | Andrew Morton <> | Subject | Re: [PATCHv3 6/8] zram: report failed read and write stats |
| |
On Thu, 16 Jan 2014 16:12:14 +0300 Sergey Senozhatsky <sergey.senozhatsky@gmail.com> wrote:
> zram accounted but did not report numbers of failed read > and write queries. make these stats available as failed_reads > and failed_writes attrs. > > Acked-by: Minchan Kim <minchan@kernel.org> > Acked-by: Jerome Marchand <jmarchan@redhat.com> > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> > --- > drivers/block/zram/zram_drv.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c > index e7102f1..9d67fbf 100644 > --- a/drivers/block/zram/zram_drv.c > +++ b/drivers/block/zram/zram_drv.c > @@ -728,6 +728,8 @@ static DEVICE_ATTR(mem_used_total, S_IRUGO, mem_used_total_show, NULL); > > ZRAM_ATTR_RO(num_reads); > ZRAM_ATTR_RO(num_writes); > +ZRAM_ATTR_RO(failed_reads); > +ZRAM_ATTR_RO(failed_writes); > ZRAM_ATTR_RO(invalid_io); > ZRAM_ATTR_RO(notify_free); > ZRAM_ATTR_RO(zero_pages); > @@ -739,6 +741,8 @@ static struct attribute *zram_disk_attrs[] = { > &dev_attr_reset.attr, > &dev_attr_num_reads.attr, > &dev_attr_num_writes.attr, > + &dev_attr_failed_reads.attr, > + &dev_attr_failed_writes.attr, > &dev_attr_invalid_io.attr, > &dev_attr_notify_free.attr, > &dev_attr_zero_pages.attr,
Documentation/blockdev/zram.txt and Documentation/ABI/testing/sysfs-block-zram need updating...
| |