Messages in this thread | | | Date | Wed, 15 Jan 2014 18:33:28 -0800 | From | "Paul E. McKenney" <> | Subject | Re: [PATCH tip/core/timers 4/4] timers: Reduce future __run_timers() latency for first add to empty list |
| |
On Wed, Jan 15, 2014 at 06:24:09PM +0100, Oleg Nesterov wrote: > On 01/14, Paul E. McKenney wrote: > > > > @@ -749,6 +749,7 @@ __mod_timer(struct timer_list *timer, unsigned long expires, > > > > base = lock_timer_base(timer, &flags); > > > > + (void)catchup_timer_jiffies(base); > > Agreed, but perhaps it would be better to do this before > all_timers++ in internal_add_timer() ?
Excellent point, changed.
> This is funny, but I already have the same change for ->next_timer, > if we add this optimization perhaps that trivial patch makes sense > too.
Yep, I queued your change in my series as well, thank you!
Thanx, Paul
| |