Messages in this thread | | | Date | Mon, 13 Jan 2014 10:47:11 +0100 | Subject | Re: [PATCH] ARM: shmobile: compile drivers/sh for CONFIG_ARCH_SHMOBILE_MULTI | From | Geert Uytterhoeven <> |
| |
Hi Ben,
On Mon, Jan 13, 2014 at 10:35 AM, Ben Dooks <ben.dooks@codethink.co.uk> wrote: > On 13/01/14 09:28, Geert Uytterhoeven wrote: >> On Fri, Jan 10, 2014 at 4:18 PM, Ben Dooks <ben.dooks@codethink.co.uk> >> wrote: >>> >>> --- a/drivers/sh/Makefile >>> +++ b/drivers/sh/Makefile >>> @@ -3,7 +3,10 @@ >>> # >>> obj-y := intc/ >>> >>> +ifeq ($(CONFIG_COMMON_CLK),n) >>> obj-$(CONFIG_HAVE_CLK) += clk/ >>> +endif >>> + >> >> >> This part breaks my Koelsch legacy (non-reference) build: >> >> arch/arm/kernel/built-in.o: In function `twd_local_timer_common_register': >> io.c:(.init.text+0x1804): undefined reference to `clk_enable' >> io.c:(.init.text+0x1828): undefined reference to `clk_get_rate' > > ... > >> >> Both of my Koelsch legacy and reference configs have CONFIG_HAVE_CLK=y, >> but only the reference once has CONFIG_COMMON_CLK=y. > > Hmm, thought undefined symbols got set to 'n'.
No, they're empty. Doh, should have realized that myself...
> I can either fix this by > > ifneq ($(CONFIG_COMMON_CLK),y) > endif
That's the typical pattern for this.
Sometimes people use
obj-$(CONFIG_COMMON_CLK)$(CONFIG_HAVE_CLK) += clk/
but that's less readable.
> or adding an extra Kconfig for SH specific legacy clock code.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |