Messages in this thread | | | Date | Mon, 13 Jan 2014 09:35:41 +0000 | From | Ben Dooks <> | Subject | Re: [PATCH] ARM: shmobile: compile drivers/sh for CONFIG_ARCH_SHMOBILE_MULTI |
| |
On 13/01/14 09:28, Geert Uytterhoeven wrote: > On Fri, Jan 10, 2014 at 4:18 PM, Ben Dooks <ben.dooks@codethink.co.uk> wrote: >> --- a/drivers/sh/Makefile >> +++ b/drivers/sh/Makefile >> @@ -3,7 +3,10 @@ >> # >> obj-y := intc/ >> >> +ifeq ($(CONFIG_COMMON_CLK),n) >> obj-$(CONFIG_HAVE_CLK) += clk/ >> +endif >> + > > This part breaks my Koelsch legacy (non-reference) build: > > arch/arm/kernel/built-in.o: In function `twd_local_timer_common_register': > io.c:(.init.text+0x1804): undefined reference to `clk_enable' > io.c:(.init.text+0x1828): undefined reference to `clk_get_rate' ... > > Both of my Koelsch legacy and reference configs have CONFIG_HAVE_CLK=y, > but only the reference once has CONFIG_COMMON_CLK=y.
Hmm, thought undefined symbols got set to 'n'.
I can either fix this by
ifneq ($(CONFIG_COMMON_CLK),y) endif
or adding an extra Kconfig for SH specific legacy clock code.
-- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius
| |