Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH v5 2/9] mfd: omap-usb-host: Get clocks based on hardware revision | Date | Fri, 10 Jan 2014 15:13:39 +0100 |
| |
On Friday 10 January 2014, Lee Jones wrote: > > > > - need_logic_fck = false; > > + /* Set all clocks as invalid to begin with */ > > + omap->ehci_logic_fck = omap->init_60m_fclk = ERR_PTR(-EINVAL); > > + omap->utmi_p1_gfclk = omap->utmi_p2_gfclk = ERR_PTR(-EINVAL); > > + omap->xclk60mhsp1_ck = omap->xclk60mhsp2_ck = ERR_PTR(-EINVAL); > > I don't think this is the correct error code. > > -EINVAL means 'invalid parameter'. > > You probably want -ENODEV or -ENOSYS ('function not implemented' > probably isn't ideal either tbh, but you get the idea). Perhaps you > can set them as NULL and check for IS_ERR_OR_NULL() instead?
I think ENODEV is ok here, I'd much prefer this over IS_ERR_OR_NULL().
Arnd
| |