Messages in this thread | | | From | David Laight <> | Subject | RE: [PATCH v2 3/4] net: make tcp_cleanup_rbuf private | Date | Fri, 10 Jan 2014 10:38:40 +0000 |
| |
From: David Miller ... > > On Thu, Jan 9, 2014 at 12:26 PM, Neal Cardwell <ncardwell@google.com> wrote: > >> On Thu, Jan 9, 2014 at 3:16 PM, Dan Williams <dan.j.williams@intel.com> wrote: > >>> net_dma was the only external user so this can become local to tcp.c > >>> again. > >> ... > >>> -void tcp_cleanup_rbuf(struct sock *sk, int copied) > >>> +static void cleanup_rbuf(struct sock *sk, int copied) > >> > >> I would vote to keep the tcp_ prefix. In the TCP code base that is the > >> more common idiom, even for internal/static TCP functions, and > >> personally I find it easier to read and work with in stack traces, > >> etc. My 2 cents. > >> > > > > Ok. It was cleanup_rbuf() in a former life, but one vote for leaving > > the name as is is enough for me. > > You can make that two votes :)
I suspect DM adds 2000 votes :-)
Keeping the prefix makes it easier to grep for, and makes it more obvious that it isn't a generic function (when being called).
David
| |