Messages in this thread | | | Date | Thu, 09 Jan 2014 15:42:32 -0500 (EST) | Subject | Re: [PATCH v2 3/4] net: make tcp_cleanup_rbuf private | From | David Miller <> |
| |
From: Dan Williams <dan.j.williams@intel.com> Date: Thu, 9 Jan 2014 12:33:29 -0800
> On Thu, Jan 9, 2014 at 12:26 PM, Neal Cardwell <ncardwell@google.com> wrote: >> On Thu, Jan 9, 2014 at 3:16 PM, Dan Williams <dan.j.williams@intel.com> wrote: >>> net_dma was the only external user so this can become local to tcp.c >>> again. >> ... >>> -void tcp_cleanup_rbuf(struct sock *sk, int copied) >>> +static void cleanup_rbuf(struct sock *sk, int copied) >> >> I would vote to keep the tcp_ prefix. In the TCP code base that is the >> more common idiom, even for internal/static TCP functions, and >> personally I find it easier to read and work with in stack traces, >> etc. My 2 cents. >> > > Ok. It was cleanup_rbuf() in a former life, but one vote for leaving > the name as is is enough for me.
You can make that two votes :)
| |