Messages in this thread | | | Date | Tue, 3 Sep 2013 16:55:20 +0800 | From | Li Zefan <> | Subject | Re: [PATCH trivial] block/ioctl.c: let code match 'kernel code style' |
| |
Please don't. Pure colding style cleanup is discouraged.
You're not going to run checkpatch.pl on the whole kernel tree and fix all the complaints, are you?
On 2013/9/3 16:29, Chen Gang wrote: > For 'switch case', remove redundancy '\t' (also can let related lines > within 80 columns) and remove redundancy empty lines, just like other > 'switch case' which match 'kernel code style' within the file. > > Let blkpg_ioctl() within 80 columns. Let 2nd line of blkdev_ioctl() and > __blkdev_driver_ioctl() align 1st line parameter's start position, just > like blk_ioctl_discard() and blk_ioctl_zeroout() within the file. > > For is_unrecognized_ioctl(), can shrink the 'return' statement into one > line (so can save 2 lines), it still matches 'kernel code style' and it > is no conflict with others within the file. > > > Signed-off-by: Chen Gang <gang.chen@asianux.com> > --- > block/ioctl.c | 216 ++++++++++++++++++++++++++++----------------------------- > 1 files changed, 105 insertions(+), 111 deletions(-)
| |