Messages in this thread | | | Date | Tue, 03 Sep 2013 17:06:13 +0800 | From | Chen Gang <> | Subject | Re: [PATCH trivial] block/ioctl.c: let code match 'kernel code style' |
| |
On 09/03/2013 04:55 PM, Li Zefan wrote: > Please don't. Pure colding style cleanup is discouraged. >
Pardon?
Do you mean "coding style", not "colding style"? (or it is my misunderstanding?).
> You're not going to run checkpatch.pl on the whole kernel tree and fix > all the complaints, are you? >
I am not going to, it seems that may be the 'job' of Joe and trivial@kernel.org?
BTW: it seems you did not redirect my mails to "/dev/null". ;-)
Thanks.
> On 2013/9/3 16:29, Chen Gang wrote: >> For 'switch case', remove redundancy '\t' (also can let related lines >> within 80 columns) and remove redundancy empty lines, just like other >> 'switch case' which match 'kernel code style' within the file. >> >> Let blkpg_ioctl() within 80 columns. Let 2nd line of blkdev_ioctl() and >> __blkdev_driver_ioctl() align 1st line parameter's start position, just >> like blk_ioctl_discard() and blk_ioctl_zeroout() within the file. >> >> For is_unrecognized_ioctl(), can shrink the 'return' statement into one >> line (so can save 2 lines), it still matches 'kernel code style' and it >> is no conflict with others within the file. >> >> >> Signed-off-by: Chen Gang <gang.chen@asianux.com> >> --- >> block/ioctl.c | 216 ++++++++++++++++++++++++++++----------------------------- >> 1 files changed, 105 insertions(+), 111 deletions(-) > > >
-- Chen Gang
| |