Messages in this thread | | | Date | Thu, 26 Sep 2013 20:16:54 -0700 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH CHAR-MISC-NEXT 2/4] Intel MIC Driver Header File Cleanups. |
| |
On Thu, Sep 26, 2013 at 06:10:01PM -0700, Sudeep Dutt wrote: > Dont use same name for header files in different folders. > > These changes were suggested by Greg Kroah-Hartman during the > code review @ https://lkml.org/lkml/2013/9/6/18 > > Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com> > Signed-off-by: Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com> > Signed-off-by: Nikhil Rao <nikhil.rao@intel.com> > Signed-off-by: Harshavardhan R Kharche <harshavardhan.r.kharche@intel.com> > Signed-off-by: Sudeep Dutt <sudeep.dutt@intel.com> > --- > drivers/misc/mic/card/mic_debugfs.c | 2 +- > drivers/misc/mic/card/mic_device.c | 2 +- > drivers/misc/mic/card/mic_virtio.c | 2 +- > drivers/misc/mic/card/mic_x100.c | 2 +- > drivers/misc/mic/common/mic_dev.h | 51 ++++++++++++++++++++++++++++++++++++ > drivers/misc/mic/common/mic_device.h | 51 ------------------------------------ > drivers/misc/mic/host/mic_boot.c | 2 +- > drivers/misc/mic/host/mic_debugfs.c | 2 +- > drivers/misc/mic/host/mic_fops.c | 2 +- > drivers/misc/mic/host/mic_intr.c | 2 +- > drivers/misc/mic/host/mic_main.c | 2 +- > drivers/misc/mic/host/mic_smpt.c | 2 +- > drivers/misc/mic/host/mic_sysfs.c | 2 +- > drivers/misc/mic/host/mic_virtio.c | 2 +- > drivers/misc/mic/host/mic_x100.c | 2 +- > 15 files changed, 64 insertions(+), 64 deletions(-) > create mode 100644 drivers/misc/mic/common/mic_dev.h > delete mode 100644 drivers/misc/mic/common/mic_device.h
git should have shown this file being renamed, not added/removed. Please use the -M option to it when generating patches so it will do the right thing here.
thanks,
greg k-h
| |