Messages in this thread | | | Date | Thu, 26 Sep 2013 20:15:21 -0700 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH CHAR-MISC-NEXT 1/4] Intel MIC Host Driver Sysfs Cleanups. |
| |
On Thu, Sep 26, 2013 at 06:09:51PM -0700, Sudeep Dutt wrote: > + Use DEVICE_ATTR_RO/RW instead of DEVICE_ATTR > + Use ATTRIBUTE_GROUPS > > These changes were suggested by Greg Kroah-Hartman during the > code review @ https://lkml.org/lkml/2013/9/6/13 > > Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com> > Signed-off-by: Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com> > Signed-off-by: Nikhil Rao <nikhil.rao@intel.com> > Signed-off-by: Harshavardhan R Kharche <harshavardhan.r.kharche@intel.com> > Signed-off-by: Sudeep Dutt <sudeep.dutt@intel.com> > ---
Ok, new kernel developer 101 training time :)
Your Subject:, while the [PATCH] part is fine the rest of the line needs to be a bit more descriptive.
As this is the "mic" subsystem, how about something like: Subject: [PATCH 1/4] misc: mic: host driver sysfs cleanups
No need for the whole "Intel MIC" stuff.
Also, as I "reported" this, you should have a: Reported-by: Greg Kroah-Hartman <...> line in the patch.
And really, all of those people reviewed and signed off on the patch? That's great, just not a normal thing.
So, can you resend these 4 patches with those things cleaned up? Same thing goes for Joe's patch, he deserves a "Reported-by:" at the very least, given that he pretty much wrote that whole patch.
thanks,
greg k-h
| |