Messages in this thread | | | Date | Tue, 17 Sep 2013 13:48:52 +0100 | From | Mark Brown <> | Subject | Re: [PATCH v2 2/4] regmap: Add regmap_fields APIs |
| |
On Sun, Sep 01, 2013 at 08:30:50PM -0700, Kuninori Morimoto wrote: > Current Linux kernel is supporting regmap_field method > and it is very useful feature. > It needs one regmap_filed for one register access.
Applied, thanks. I did make one update:
> + * A non-zero will be returned when fields access enable, > + * a zero will be returned in single field. > + */ > +int regmap_fields_enable(struct regmap_field *field) > +{ > + return field->id_size && field->id_offset; > +} > +EXPORT_SYMBOL_GPL(regmap_fields_enable);
This seems like it should be something like _is_present() - the name makes me think it will turn something on, not check that something is there. I removed it since it's not used by the following patches and I didn't notice earlier when I initially looked at the patches during the merge window. [unhandled content-type:application/pgp-signature] | |