lkml.org 
[lkml]   [2013]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 4/4] ASoC: rsnd: use regmap instead of original register mapping method
On Sun, Sep 01, 2013 at 08:32:45PM -0700, Kuninori Morimoto wrote:

> +void rsnd_write(struct rsnd_priv *priv,
> + struct rsnd_mod *mod,
> + enum rsnd_reg reg, u32 data)
> +{
> + struct rsnd_gen *gen = rsnd_priv_to_gen(priv);
> +
> + if (regmap_fields_enable(gen->regs[reg]))
> + regmap_fields_write(gen->regs[reg], rsnd_mod_id(mod), data);
> + else
> + regmap_field_write(gen->regs[reg], data);
> +}

Ah, sorry - I see you are actually using fields_enable(). I must've
searched for the wrong thing. However looking at this I'm not sure that
this is a good use anyway, it seems like the caller should know if the
register it is writing to is in one of the repeated blocks. Can you
provide a bit more detail as to what's going on here?
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2013-09-17 15:21    [W:0.307 / U:0.764 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site