Messages in this thread | | | Date | Thu, 12 Sep 2013 13:41:13 +0530 | From | "Srivatsa S. Bhat" <> | Subject | Re: [PATCH 2/5] cpufreq: don't break string in print statements |
| |
On 09/12/2013 10:55 AM, Viresh Kumar wrote: > As a rule its better not to break string (quoted inside "") in a print statement > even if it crosses 80 column boundary as that may introduce unwanted bugs and so > this patch rewrites one of the print statements.. >
Ok, if that is the convention, then so be it.
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Regards, Srivatsa S. Bhat
> --- > drivers/cpufreq/cpufreq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > index 28477eb..31f7845 100644 > --- a/drivers/cpufreq/cpufreq.c > +++ b/drivers/cpufreq/cpufreq.c > @@ -1192,8 +1192,8 @@ static int __cpufreq_remove_dev_prepare(struct device *dev, > unlock_policy_rwsem_write(cpu); > > if (!frozen) { > - pr_debug("%s: policy Kobject moved to cpu: %d " > - "from: %d\n",__func__, new_cpu, cpu); > + pr_debug("%s: policy Kobject moved to cpu: %d from: %d\n", > + __func__, new_cpu, cpu); > } > } > } >
| |