lkml.org 
[lkml]   [2013]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 5/5] cpufreq: use correct values of cpus in __cpufreq_remove_dev_finish()
    From
    On 12 September 2013 12:10, Srivatsa S. Bhat
    <srivatsa.bhat@linux.vnet.ibm.com> wrote:
    > That said, your fix doesn't look correct. See below.

    I thought I was perfect !! :(

    > ... and change this suitably (from 1 to 0 etc..) ? To add to it, it will look more
    > clear as well:
    >
    > if (cpus == 0) {
    > /* No cpus in policy, so free it */
    > } else {
    > /* Restart governor */
    > }

    Currently cpus never become zero as we clear mask only while there are
    more than one cpu in a policy... Wait let me see what's the cleanest way
    to get this fixed..


    \
     
     \ /
      Last update: 2013-09-12 10:41    [W:2.261 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site