Messages in this thread | | | Date | Fri, 09 Aug 2013 10:35:50 -0600 | From | Stephen Warren <> | Subject | Re: [PATCH v2 3/3] Documentation: dt: hwmon: add OF document for lm90 |
| |
On 08/09/2013 12:10 AM, Wei Ni wrote: > On 08/09/2013 01:37 AM, Stephen Warren wrote: >> On 08/08/2013 12:56 AM, Wei Ni wrote: >>> Add OF document for lm90 in Documentation/devicetree/. >> >>> diff --git a/Documentation/devicetree/bindings/hwmon/lm90.txt b/Documentation/devicetree/bindings/hwmon/lm90.txt
>>> +- interrupts: lm90 can support interrupt mode, you can set interrupt here. >> >> You might want to mention that a single entry ("specifier") is expected >> in the list. > > Sorry, I didn't get your point, could you explain more?
In general, a device may have more than one interrupt output. Hence in general, the interrupts property is a list of 1 or more interrupt specifiers. In this case, that list should be a single entry. The binding should state this. how about:
---------- Optional properties: interrupts: Contains a single interrupt specifier which describes the LM90 XXXX output. See interrupt-controller/interrupts.txt for the format. ----------
(where you'd replace XXXX with the pin/signal name from the datasheet).
| |