Messages in this thread | | | Date | Fri, 9 Aug 2013 14:10:15 +0800 | From | Wei Ni <> | Subject | Re: [PATCH v2 3/3] Documentation: dt: hwmon: add OF document for lm90 |
| |
On 08/09/2013 01:37 AM, Stephen Warren wrote: > On 08/08/2013 12:56 AM, Wei Ni wrote: >> Add OF document for lm90 in Documentation/devicetree/. > >> diff --git a/Documentation/devicetree/bindings/hwmon/lm90.txt b/Documentation/devicetree/bindings/hwmon/lm90.txt > >> +Required node properties: >> +- compatible: manufacture and chip name, >> + which are listed in the Documentation/hwmon/lm90 > > You need to specify the exact values here. DT binding documentations > should be OS-agnostic, and hence can't depend on Linux-specific > documentation or other details.
Ok, I will list it.
> >> +Optional properties: >> +- vdd-supply: vdd regulator for the supply voltage. If this is not set, > > s/set/present/.
Oh, yes, I will change it.
> >> +- interrupts: lm90 can support interrupt mode, you can set interrupt here. > > You might want to mention that a single entry ("specifier") is expected > in the list.
Sorry, I didn't get your point, could you explain more?
>
| |